yahoo-eng-team team mailing list archive

[OpenStack Infra <1687115@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/463506
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=6ae168544ac1fdf4edd8c8b97c22ccafabc643ac
Submitter: Jenkins
Branch:    master

commit 6ae168544ac1fdf4edd8c8b97c22ccafabc643ac
Author: rocky <haigang.xu@xxxxxxxxxxxx>
Date:   Tue May 9 17:21:23 2017 +0800

    Change LDAPServerConnectionError
    
    The base class of LDAPServerConnectionError is changed from Error to
    UnexpectedError so that it will result in HTTP 500 instead of 504. It
    is inappropriate to be telling API users that there was a timeout,
    which implies that LDAP is being used when they should not know that.
    
    Change-Id: Ic9ac3443bb2117e33b1ec66d570ae2a7a2f62df2
    Closes-Bug: #1687115


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1687115

Title:
  LDAPServerConnectionError gives out too much info

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  Exception LDAPServerConnectionError
  (https://git.openstack.org/cgit/openstack/keystone/tree/keystone/exception.py?h=12.0.0.0b1#n597)
  is now implemented as a subclass of Error. It gives out too much info
  about setup (that LDAP is used) and it should not set its error code.

  Instead, it should be implemented as subclass of UnexpectedError and
  debug_message_format should be used, like in
  https://git.openstack.org/cgit/openstack/keystone/tree/keystone/exception.py?h=12.0.0.0b1#n491

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1687115/+subscriptions