yahoo-eng-team team mailing list archive

[OpenStack Infra <1691780@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/466003
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ae6e4f1bc14e2e1d947554799fc9d9b81fe75288
Submitter: Jenkins
Branch:    master

commit ae6e4f1bc14e2e1d947554799fc9d9b81fe75288
Author: Chris Friesen <chris.friesen@xxxxxxxxxxxxx>
Date:   Thu May 18 09:05:17 2017 -0600

    correctly log port id in neutron api
    
    Fix the log to correctly report the port id in the log.  As it
    stands, it's reporting the last port id from the previous loop over
    the ports.
    
    Change-Id: I1f3dec9fd05ffa9f11f82576d0755d334aca01a0
    Closes-Bug: #1691780


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1691780

Title:
  port id is incorrectly logged in _update_port_binding_for_instance

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  At line 2484 of
  https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py
  the code is accessing  p[‘id’]  in the LOG.info block,  but that means
  it logs the last entry that it iterated over in the previous loop over
  the ports rather than the port_id being processed in the current loop.

  We see this when we have multiple ports, it suggests it is updating
  the same port over and over, when its actually working properly

  2017-05-10 16:39:32.936 72563 INFO nova.network.neutronv2.api [req-
  56a25602-5598-48c5-977f-7d76582c2832 a5f3dc1ec00e4ee4a9c7d53163d3508e
  7c2d9914234f4a0ab5e72d802e0f9782 - - -] [instance: d36a69e3-77ba-4f27
  -a15d-be24eee0ae81] Updating port ffe01a49-a569-435d-96f3-18da8a6ca27b
  with attributes {'binding:profile': {}, 'binding:host_id':
  'compute-6'}

  2017-05-10 16:39:33.905 72563 INFO nova.network.neutronv2.api [req-
  56a25602-5598-48c5-977f-7d76582c2832 a5f3dc1ec00e4ee4a9c7d53163d3508e
  7c2d9914234f4a0ab5e72d802e0f9782 - - -] [instance: d36a69e3-77ba-4f27
  -a15d-be24eee0ae81] Updating port ffe01a49-a569-435d-96f3-18da8a6ca27b
  with attributes {'binding:profile': {}, 'binding:host_id':
  'compute-6'}

  2017-05-10 16:39:35.084 72563 INFO nova.network.neutronv2.api [req-
  56a25602-5598-48c5-977f-7d76582c2832 a5f3dc1ec00e4ee4a9c7d53163d3508e
  7c2d9914234f4a0ab5e72d802e0f9782 - - -] [instance: d36a69e3-77ba-4f27
  -a15d-be24eee0ae81] Updating port ffe01a49-a569-435d-96f3-18da8a6ca27b
  with attributes {'binding:profile': {}, 'binding:host_id':
  'compute-6'}

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1691780/+subscriptions