yahoo-eng-team team mailing list archive

[OpenStack Infra <1697383@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/473311
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cf4e857dd2d7e6a7a63729257fdad2b599df8fc8
Submitter: Jenkins
Branch:    master

commit cf4e857dd2d7e6a7a63729257fdad2b599df8fc8
Author: Kevin Benton <kevin@xxxxxxxxxx>
Date:   Mon Jun 12 01:36:59 2017 -0700

    Use e.exc_type instead of calling str on exception
    
    This fixes the usage of the oslo RemoteError exception checking
    in the Linux Bridge trunk driver to stop calling 'str' on the
    exception and just check the 'exc_type' attribute like we do
    in the other agent code so it's safe to use with unicode.
    
    Change-Id: I352ed422550343118319f8e83c4979f290f161f0
    Closes-Bug: #1697383


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1697383

Title:
  unsafe str call in linuxbridge trunk driver

Status in neutron:
  Fix Released

Bug description:
  Failure encountered in unicode envs.

    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager [req-bfc74178-179f-4abd-bdb2-25d66ce36107 - - - - -] Error during notification for neutron.services.trunk.drivers.linuxbridge.agent.driver.LinuxBridgeTrunkDriver.agent_port_change--9223372036853960796 port_device, after_update
    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager Traceback (most recent call last):
    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager   File "/usr/lib/python2.7/site-packages/neutron/callbacks/manager.py", line 146, in _notify_loop
    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager     callback(resource, event, trigger, **kwargs)
    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager   File "/usr/lib/python2.7/site-packages/neutron/services/trunk/drivers/linuxbridge/agent/driver.py", line 94, in agent_port_change
    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager     trunk = self._tapi.get_trunk(context, device_details['port_id'])
    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager   File "/usr/lib/python2.7/site-packages/neutron/services/trunk/drivers/linuxbridge/agent/driver.py", line 196, in get_trunk
    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager     self.put_trunk(port_id, self._fetch_trunk(context, port_id))
    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager   File "/usr/lib/python2.7/site-packages/neutron/services/trunk/drivers/linuxbridge/agent/driver.py", line 140, in _fetch_trunk
    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager     if 'CallbackNotFound' not in str(e):
    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager UnicodeEncodeError: 'ascii' codec can't encode characters in position 31-35: ordinal not in range(128)
    2017-06-12 06:49:50.591 20776 ERROR neutron.callbacks.manager

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1697383/+subscriptions