← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1697537] [NEW] cinder v3 api, validate_bdm calling ._check_attach_and_reserve_volume without bdm

 

Public bug reported:

This was found while testing live migration with the new cinder v3 api
using a bfv instance.

In compute.manager._validate_bdm(...) is this:
...
    if (min_compute_version >=
       BFV_RESERVE_MIN_COMPUTE_VERSION):
        volume = self._check_attach_and_reserve_volume(
           context, volume_id, instance)

The problem is that if the cinder v3 api is being used, the bdm must be
supplied to the _check_attach_and_reserve_volume method. So this should
be:

    if (min_compute_version >=
       BFV_RESERVE_MIN_COMPUTE_VERSION):
        volume = self._check_attach_and_reserve_volume(
           context, volume_id, instance, bdm)

The error happens in _check_attach_and_reserve_volume:

2017-06-12 09:23:08.318 ^[[00;32mDEBUG cinderclient.v3.client [^[[01;36mreq-e6b9a3ed-b613-4fe2-8cd2-d1e2907f5f6d ^[[00;36mdemo admin^[[00;32m] ^[[01;35m^[[00;32mGET call to cinderv3 for http://192.168.0.181:8776/v3/f0ae34bbad3f4f4883f298e0049b4872/volumes/383f401e-7efd-49a7-8f8f-bbde13bc6d75 used request id req-d8c89300-e4d3-4171-93a6-7b0e789cdde2^[[00m ^[[00;33mfrom (pid=30199) request /usr/local/lib/python2.7/dist-packages/keystoneauth1/session.py:640^[[00m
2017-06-12 09:23:08.318 ^[[01;31mERROR nova.compute.api [^[[01;36mreq-e6b9a3ed-b613-4fe2-8cd2-d1e2907f5f6d ^[[00;36mdemo admin^[[01;31m] ^[[01;35m^[[01;31mUnable to perform attachment_create due to missing volume_bdm.^[[00m

git show:
commit d147277b8f3a0129755b5d54b4416ea2f50a84ad
Merge: 4e6d6fd f69d495
Author: Jenkins <jenkins@xxxxxxxxxxxxxxxxxxxx>
Date:   Fri Jun 9 16:11:29 2017 +0000

    Merge "Add earliest-version tags for stable branch renos"

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1697537

Title:
  cinder v3 api, validate_bdm calling ._check_attach_and_reserve_volume
  without bdm

Status in OpenStack Compute (nova):
  New

Bug description:
  This was found while testing live migration with the new cinder v3 api
  using a bfv instance.

  In compute.manager._validate_bdm(...) is this:
  ...
      if (min_compute_version >=
         BFV_RESERVE_MIN_COMPUTE_VERSION):
          volume = self._check_attach_and_reserve_volume(
             context, volume_id, instance)

  The problem is that if the cinder v3 api is being used, the bdm must
  be supplied to the _check_attach_and_reserve_volume method. So this
  should be:

      if (min_compute_version >=
         BFV_RESERVE_MIN_COMPUTE_VERSION):
          volume = self._check_attach_and_reserve_volume(
             context, volume_id, instance, bdm)

  The error happens in _check_attach_and_reserve_volume:

  2017-06-12 09:23:08.318 ^[[00;32mDEBUG cinderclient.v3.client [^[[01;36mreq-e6b9a3ed-b613-4fe2-8cd2-d1e2907f5f6d ^[[00;36mdemo admin^[[00;32m] ^[[01;35m^[[00;32mGET call to cinderv3 for http://192.168.0.181:8776/v3/f0ae34bbad3f4f4883f298e0049b4872/volumes/383f401e-7efd-49a7-8f8f-bbde13bc6d75 used request id req-d8c89300-e4d3-4171-93a6-7b0e789cdde2^[[00m ^[[00;33mfrom (pid=30199) request /usr/local/lib/python2.7/dist-packages/keystoneauth1/session.py:640^[[00m
  2017-06-12 09:23:08.318 ^[[01;31mERROR nova.compute.api [^[[01;36mreq-e6b9a3ed-b613-4fe2-8cd2-d1e2907f5f6d ^[[00;36mdemo admin^[[01;31m] ^[[01;35m^[[01;31mUnable to perform attachment_create due to missing volume_bdm.^[[00m

  git show:
  commit d147277b8f3a0129755b5d54b4416ea2f50a84ad
  Merge: 4e6d6fd f69d495
  Author: Jenkins <jenkins@xxxxxxxxxxxxxxxxxxxx>
  Date:   Fri Jun 9 16:11:29 2017 +0000

      Merge "Add earliest-version tags for stable branch renos"

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1697537/+subscriptions


Follow ups