← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1697937] Re: TC shouldn't raise an exception when deleting qdisc if device doesn't exist

 

Reviewed:  https://review.openstack.org/474244
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0a185354a16d2bbd87bea4371933032d0f349e60
Submitter: Jenkins
Branch:    master

commit 0a185354a16d2bbd87bea4371933032d0f349e60
Author: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@xxxxxxxxx>
Date:   Wed Jun 14 15:46:28 2017 +0100

    TC doesn't rise exception if device doesn't exist
    
    If device doesn't exit, TC doesn't need to raise an exception
    during the deletion of the qdisc.
    
    In iproute2 source code [1], the error code used is "1".
    
    [1] https://kernel.googlesource.com/pub/scm/linux/kernel/git/shemminger/iproute2/+/master/tc/tc_qdisc.c#188
    
    Change-Id: I9abecd6ef9d74abff27fb0ed0f5f4535c0622fd6
    Closes-Bug: #1697937


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1697937

Title:
  TC shouldn't raise an exception when deleting qdisc if device doesn't
  exist

Status in neutron:
  Fix Released

Bug description:
  TC shouldn't raise an exception when deleting qdisc if device doesn't
  exist.

  When Linux Bridge agent deletes a port or detect a port was deleted,
  QoS extension is informed to clean any traffic shapping in this port
  by deleting the qdisc. If the port was already deleted, TC will raise
  an exception:

  ProcessExecutionError: Exit code: 1; Stdin: ; Stdout: ; Stderr: Cannot
  find device "tape0f6e79a-0b"

  Logs: http://logs.openstack.org/85/473685/3/check/gate-tempest-dsvm-
  neutron-scenario-linuxbridge-ubuntu-xenial-
  nv/427484d/logs/screen-q-agt.txt.gz?level=WARNING#_Jun_13_07_36_14_943304

  In this case, TC should catch silently this exception.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1697937/+subscriptions


References