yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #65549
[Bug 1679976] Re: Quobyte driver may fail to raise an error upon error code 4 on volume mounting
Reviewed: https://review.openstack.org/453537
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ffb228bcc221162d77e2def9b81895ecb4bf48b7
Submitter: Jenkins
Branch: master
commit ffb228bcc221162d77e2def9b81895ecb4bf48b7
Author: Silvan Kaiser <silvan@xxxxxxxxxxx>
Date: Wed Apr 5 11:04:33 2017 +0200
Removes potentially bad exit value from accepted list in Quobyte volume driver
This disallows exit code 4 in the list of valid exit codes of the execute
call for mounting Quobyte volumes. As exit code 0 is the default value
for the allowed exit codes the whole check_exit_codes argument is
omitted.
Furthermore this updates the (dis-)connect volume sync locks to be
Quobyte specific.
Closes-Bug: #1679976
Change-Id: I87b74535bd1a2045948a56d1648cd587146facb7
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1679976
Title:
Quobyte driver may fail to raise an error upon error code 4 on volume
mounting
Status in OpenStack Compute (nova):
Fix Released
Bug description:
The Quobyte libvirt volume driver currently accepts exit codes [0,4] when mounting a Quobyte volume (https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/quobyte.py#L55).
However error code 4 might be thrown in acceptable (already mounted) and unacceptable cases (specific bad state). As the driver already checks for existence of the mount when connecting a volume the error code should be removed as acceptable and failed upon.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1679976/+subscriptions
References