← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1703584] [NEW] Get rid of redundant cinder api calls

 

Public bug reported:

During executing tenant_limit_usages quotas function here [0] we get
information about cinder volumes/snapshots/gigabites usage. Like this:

{u'maxTotalBackupGigabytes': 1000,
 u'maxTotalBackups': 10,
 u'maxTotalSnapshots': 10,
 u'maxTotalVolumeGigabytes': 1000,
 u'maxTotalVolumes': 10,
 u'totalBackupGigabytesUsed': 1,
 u'totalBackupsUsed': 1,
 u'totalGigabytesUsed': 8,
 u'totalSnapshotsUsed': 1,
 u'totalVolumesUsed': 6
}

After it here [1] we trying to get the same information as we've already got and add it one more time to limits dict here [2]
Also these calls slows down the application, so we need to get rid of them.

[0] -
https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L489

https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L490-L491
[2] - https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L497-L499

** Affects: horizon
     Importance: Undecided
     Assignee: Michael Dovgal (mdovgal)
         Status: In Progress

** Description changed:

  During executing tenant_limit_usages quotas function here [0] we get
  information about cinder volumes/snapshots/gigabites usage. Like this:
  
  {u'maxTotalBackupGigabytes': 1000,
-  u'maxTotalBackups': 10,
-  u'maxTotalSnapshots': 10,
-  u'maxTotalVolumeGigabytes': 1000,
-  u'maxTotalVolumes': 10,
-  u'totalBackupGigabytesUsed': 1,
-  u'totalBackupsUsed': 1,
-  u'totalGigabytesUsed': 8,
-  u'totalSnapshotsUsed': 1,
-  u'totalVolumesUsed': 6
+  u'maxTotalBackups': 10,
+  u'maxTotalSnapshots': 10,
+  u'maxTotalVolumeGigabytes': 1000,
+  u'maxTotalVolumes': 10,
+  u'totalBackupGigabytesUsed': 1,
+  u'totalBackupsUsed': 1,
+  u'totalGigabytesUsed': 8,
+  u'totalSnapshotsUsed': 1,
+  u'totalVolumesUsed': 6
  }
  
- After it here [1] we trying to get the same information as we've already got.
+ After it here [1] we trying to get the same information as we've already got and add it one more time to limits dict here [2]
  Also these calls slows down the application, so we need to get rid of them.
  
- 
- [0] - https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L489
+ [0] -
+ https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L489
  
  https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L490-L491
+ [2] - https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L497-L499

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1703584

Title:
   Get rid of redundant cinder api calls

Status in OpenStack Dashboard (Horizon):
  In Progress

Bug description:
  During executing tenant_limit_usages quotas function here [0] we get
  information about cinder volumes/snapshots/gigabites usage. Like this:

  {u'maxTotalBackupGigabytes': 1000,
   u'maxTotalBackups': 10,
   u'maxTotalSnapshots': 10,
   u'maxTotalVolumeGigabytes': 1000,
   u'maxTotalVolumes': 10,
   u'totalBackupGigabytesUsed': 1,
   u'totalBackupsUsed': 1,
   u'totalGigabytesUsed': 8,
   u'totalSnapshotsUsed': 1,
   u'totalVolumesUsed': 6
  }

  After it here [1] we trying to get the same information as we've already got and add it one more time to limits dict here [2]
  Also these calls slows down the application, so we need to get rid of them.

  [0] -
  https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L489

  https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L490-L491
  [2] - https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L497-L499

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1703584/+subscriptions


Follow ups