yahoo-eng-team team mailing list archive

[OpenStack Infra <1703584@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/482486
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d132c2eb11bdf4a28bedcd4061d5b76b4402a08e
Submitter: Jenkins
Branch:    master

commit d132c2eb11bdf4a28bedcd4061d5b76b4402a08e
Author: Mykhailo Dovgal <mdovgal@xxxxxxxxxxxx>
Date:   Mon Jul 10 19:16:06 2017 +0300

    Get rid of redundant cinder api calls
    
    During executing tenant_limit_usages quotas function we get
    information about cinder volumes/snapshots/gigabites usage
    that we've already had after tenant_absolute_limits call.
    Getting this information we make more api calls that slow down
    our application.
    
    This patch fixes this issue.
    
    Closes-Bug: #1703584
    Change-Id: Ia6d2dbb8f18ce93f71668d6ebd2689b851586ca9


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1703584

Title:
   Get rid of redundant cinder api calls

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  During executing tenant_limit_usages quotas function here [0] we get
  information about cinder volumes/snapshots/gigabites usage. Like this:

  {u'maxTotalBackupGigabytes': 1000,
   u'maxTotalBackups': 10,
   u'maxTotalSnapshots': 10,
   u'maxTotalVolumeGigabytes': 1000,
   u'maxTotalVolumes': 10,
   u'totalBackupGigabytesUsed': 1,
   u'totalBackupsUsed': 1,
   u'totalGigabytesUsed': 8,
   u'totalSnapshotsUsed': 1,
   u'totalVolumesUsed': 6
  }

  After it here [1] we trying to get the same information as we've already got and add it one more time to limits dict here [2]
  Also these calls slows down the application, so we need to get rid of them.

  [0] -
  https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L489

  https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L490-L491
  [2] - https://github.com/openstack/horizon/blob/29a6ed4cc06ef9cbadee311c947fe19308a387ed/openstack_dashboard/usage/quotas.py#L497-L499

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1703584/+subscriptions