yahoo-eng-team team mailing list archive

[OpenStack Infra <1696152@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/487126
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f468dae28a0a7bb547ca67dba667360bd1777c30
Submitter: Jenkins
Branch:    master

commit f468dae28a0a7bb547ca67dba667360bd1777c30
Author: Balazs Gibizer <balazs.gibizer@xxxxxxxxxxxx>
Date:   Tue Jul 25 16:46:26 2017 +0200

    rename binary to source in versioned notifications
    
    In the nova notification code path the nova service / binary names
    are hardcoded. There is a possible confusion as the REST API uses
    'nova-osapi_compute' while the notifications use 'nova-api'
    as the name of the nova compute service binary.
    
    To make it clear that these names used in the notifications
    are not the official service names the field storing it is renamed
    from 'binary' to 'source'. This renaming means that the version of
    NotificationPublisher ovo needed a major version bump. However this
    does not effect the consumers of the notifications as the
    NotificationPublisher is not directly serialized to the payload wire
    format. Instead the value  of the 'source' and 'host' fields are
    dumped into the publisher_id field of the notification envelope.
    Therefore this patch does not introduce a backward incompatible
    change from the notification consumer perspective.
    
    A subsequent patch will change this field to an enum to furter clarify
    the possible values for notifications.
    
    Change-Id: I95b5b0826190d396efe7bfc017f6081a6356da65
    Related-Bug: #1696152


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1696152

Title:
  nova notifications use nova-api as binary name instead of nova-
  osapi_compute

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  There are multiple places in nova where the binary of the nova api
  service is referred as 'nova-api'[1] but in fact the correct name of
  that binary is 'nova-osapi_compute' [2]

  
  [1]https://github.com/openstack/nova/search?utf8=%E2%9C%93&q=binary%3Dnova-api&type=
  [2]https://github.com/openstack/nova/blob/a818049554f61316930c7122bb0831b6372fadc0/api-guide/source/general_info.rst

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1696152/+subscriptions