← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1715451] Re: Castellan 0.13.0 doesn't work with ConfKeyManager due to missing list() abstract method

 

Reviewed:  https://review.openstack.org/501398
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=fa6951c55b5462d6ddca04361363db0c57ce66e2
Submitter: Jenkins
Branch:    master

commit fa6951c55b5462d6ddca04361363db0c57ce66e2
Author: Sean McGinnis <sean.mcginnis@xxxxxxxxxx>
Date:   Wed Sep 6 14:42:04 2017 -0500

    Implement keymgr list() method
    
    Castellan KeyManager has added an abstract list() method starting
    in release 0.13.0. We are currently safe since upper constraints
    cap it at 0.12.0, but we will want to raise those constraints
    soon.
    
    This method isn't actually used in the Cinder code, but since it's
    an ABC abstract method we must implement it in our ConfKeyMgr. This
    just adds a basic skeleton so we don't blow up on missing the method.
    
    Change-Id: Ie2b2aef40b4de36d011c7efa0ab5af5c9581a63d
    Closes-bug: #1715451


** Changed in: cinder
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1715451

Title:
  Castellan 0.13.0 doesn't work with ConfKeyManager due to missing
  list() abstract method

Status in castellan:
  New
Status in Cinder:
  Fix Released
Status in OpenStack Compute (nova):
  In Progress
Status in OpenStack Global Requirements:
  New

Bug description:
  Seen here: https://review.openstack.org/#/c/500770/

  http://logs.openstack.org/70/500770/7/check/gate-tempest-dsvm-neutron-
  full-ubuntu-
  xenial/b813494/logs/screen-c-api.txt.gz?level=TRACE#_Sep_06_17_25_08_182255

  This change in castellan 0.13.0 breaks cinder's ConfKeyManager:

  https://github.com/openstack/castellan/commit/1a13c2b2030390e3c0a5d498da486d92ddd1152c

  Because the Cinder ConfKeyManager extends the abstract KeyManager
  class in castellan but doesn't implement the list() method.

To manage notifications about this bug go to:
https://bugs.launchpad.net/castellan/+bug/1715451/+subscriptions