yahoo-eng-team team mailing list archive

[OpenStack Infra <1715451@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/502580
Committed: https://git.openstack.org/cgit/openstack/castellan/commit/?id=ffd9f484df8d4c6c7de36313beb3a76f0daa8296
Submitter: Jenkins
Branch:    master

commit ffd9f484df8d4c6c7de36313beb3a76f0daa8296
Author: Kaitlin Farr <kaitlin.farr@xxxxxxxxxx>
Date:   Mon Sep 11 16:54:28 2017 -0400

    Makes list method not abstract
    
    Any implementations of key_manager that don't have "list"
    defined (i.e. ConfKeyManager in Nova and Cinder) will not be
    instantiable if they try to use a version of Castellan
    that was released after "list" was added. Adds a default
    implementation of "list" that returns nothing for backwards
    compatibility.
    
    Closes-Bug: #1715451
    Change-Id: I1e413831163bffaed3a2580f039e242da7d303f8


** Changed in: castellan
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1715451

Title:
  Castellan 0.13.0 doesn't work with ConfKeyManager due to missing
  list() abstract method

Status in castellan:
  Fix Released
Status in Cinder:
  Fix Released
Status in OpenStack Compute (nova):
  In Progress
Status in OpenStack Global Requirements:
  New

Bug description:
  Seen here: https://review.openstack.org/#/c/500770/

  http://logs.openstack.org/70/500770/7/check/gate-tempest-dsvm-neutron-
  full-ubuntu-
  xenial/b813494/logs/screen-c-api.txt.gz?level=TRACE#_Sep_06_17_25_08_182255

  This change in castellan 0.13.0 breaks cinder's ConfKeyManager:

  https://github.com/openstack/castellan/commit/1a13c2b2030390e3c0a5d498da486d92ddd1152c

  Because the Cinder ConfKeyManager extends the abstract KeyManager
  class in castellan but doesn't implement the list() method.

To manage notifications about this bug go to:
https://bugs.launchpad.net/castellan/+bug/1715451/+subscriptions