yahoo-eng-team team mailing list archive

[Sean McGinnis <sean.mcginnis@xxxxxxxxx>]

Public bug reported:

Attempting to clean out some old constants that have been marked
deprecated in os-brick for over a year. Job failures show there are some
libvirt volume drivers still using the old constants.

Traceback (most recent call last):
Oct 05 04:47:09.563746 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/usr/local/bin/nova-compute", line 10, in <module>
Oct 05 04:47:09.563870 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     sys.exit(main())
Oct 05 04:47:09.564004 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/cmd/compute.py", line 59, in main
Oct 05 04:47:09.564117 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     topic=compute_rpcapi.RPC_TOPIC)
Oct 05 04:47:09.564225 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/service.py", line 258, in create
Oct 05 04:47:09.564353 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     periodic_interval_max=periodic_interval_max)
Oct 05 04:47:09.564461 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/service.py", line 127, in __init__
Oct 05 04:47:09.564566 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     self.manager = manager_class(host=self.host, *args, **kwargs)
Oct 05 04:47:09.564692 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/compute/manager.py", line 535, in __init__
Oct 05 04:47:09.564803 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     self.driver = driver.load_compute_driver(self.virtapi, compute_driver)
Oct 05 04:47:09.564915 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/virt/driver.py", line 1609, in load_compute_driver
Oct 05 04:47:09.565039 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     virtapi)
Oct 05 04:47:09.565143 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/usr/local/lib/python2.7/dist-packages/oslo_utils/importutils.py", line 44, in import_object
Oct 05 04:47:09.565246 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     return import_class(import_str)(*args, **kwargs)
Oct 05 04:47:09.565349 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 337, in __init__
Oct 05 04:47:09.565453 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     self.volume_drivers = self._get_volume_drivers()
Oct 05 04:47:09.565556 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 395, in _get_volume_drivers
Oct 05 04:47:09.565684 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     driver_registry[driver_type] = driver_class(self._host)
Oct 05 04:47:09.565822 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/virt/libvirt/volume/drbd.py", line 29, in __init__
Oct 05 04:47:09.565929 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     connector.DRBD, utils.get_root_helper())
Oct 05 04:47:09.566068 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova AttributeError: 'module' object has no attribute 'DRBD'
Oct 05 04:47:09.566192 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova 
Oct 05 04:47:09.719027 ubuntu-xenial-rax-ord-11225566 systemd[1]: devstack@n-cpu.service: Main process exited, code=exited, status=1/FAILURE
Oct 05 04:47:09.719269 ubuntu-xenial-rax-ord-11225566 systemd[1]: devstack@n-cpu.service: Unit entered failed state.
Oct 05 04:47:09.719303 ubuntu-xenial-rax-ord-11225566 systemd[1]: devstack@n-cpu.service: Failed with result 'exit-code'.

These just need to be updated to point to the new constants.

This change was done is os-brick 1.6.0. All the way back to Newton, our
minimum for os-brick is 1.6.2, so should be safe to remove the old
constants and use the new ones.

** Affects: nova
     Importance: Undecided
     Assignee: Sean McGinnis (sean-mcginnis)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Sean McGinnis (sean-mcginnis)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1721993

Title:
  libvirt volume drivers using deprecated os-brick constants

Status in OpenStack Compute (nova):
  New

Bug description:
  Attempting to clean out some old constants that have been marked
  deprecated in os-brick for over a year. Job failures show there are
  some libvirt volume drivers still using the old constants.

  Traceback (most recent call last):
  Oct 05 04:47:09.563746 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/usr/local/bin/nova-compute", line 10, in <module>
  Oct 05 04:47:09.563870 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     sys.exit(main())
  Oct 05 04:47:09.564004 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/cmd/compute.py", line 59, in main
  Oct 05 04:47:09.564117 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     topic=compute_rpcapi.RPC_TOPIC)
  Oct 05 04:47:09.564225 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/service.py", line 258, in create
  Oct 05 04:47:09.564353 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     periodic_interval_max=periodic_interval_max)
  Oct 05 04:47:09.564461 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/service.py", line 127, in __init__
  Oct 05 04:47:09.564566 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     self.manager = manager_class(host=self.host, *args, **kwargs)
  Oct 05 04:47:09.564692 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/compute/manager.py", line 535, in __init__
  Oct 05 04:47:09.564803 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     self.driver = driver.load_compute_driver(self.virtapi, compute_driver)
  Oct 05 04:47:09.564915 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/virt/driver.py", line 1609, in load_compute_driver
  Oct 05 04:47:09.565039 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     virtapi)
  Oct 05 04:47:09.565143 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/usr/local/lib/python2.7/dist-packages/oslo_utils/importutils.py", line 44, in import_object
  Oct 05 04:47:09.565246 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     return import_class(import_str)(*args, **kwargs)
  Oct 05 04:47:09.565349 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 337, in __init__
  Oct 05 04:47:09.565453 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     self.volume_drivers = self._get_volume_drivers()
  Oct 05 04:47:09.565556 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 395, in _get_volume_drivers
  Oct 05 04:47:09.565684 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     driver_registry[driver_type] = driver_class(self._host)
  Oct 05 04:47:09.565822 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova   File "/opt/stack/new/nova/nova/virt/libvirt/volume/drbd.py", line 29, in __init__
  Oct 05 04:47:09.565929 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova     connector.DRBD, utils.get_root_helper())
  Oct 05 04:47:09.566068 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova AttributeError: 'module' object has no attribute 'DRBD'
  Oct 05 04:47:09.566192 ubuntu-xenial-rax-ord-11225566 nova-compute[31743]: ERROR nova 
  Oct 05 04:47:09.719027 ubuntu-xenial-rax-ord-11225566 systemd[1]: devstack@n-cpu.service: Main process exited, code=exited, status=1/FAILURE
  Oct 05 04:47:09.719269 ubuntu-xenial-rax-ord-11225566 systemd[1]: devstack@n-cpu.service: Unit entered failed state.
  Oct 05 04:47:09.719303 ubuntu-xenial-rax-ord-11225566 systemd[1]: devstack@n-cpu.service: Failed with result 'exit-code'.

  These just need to be updated to point to the new constants.

  This change was done is os-brick 1.6.0. All the way back to Newton,
  our minimum for os-brick is 1.6.2, so should be safe to remove the old
  constants and use the new ones.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1721993/+subscriptions