yahoo-eng-team team mailing list archive

[OpenStack Infra <1721993@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/510311
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3daeb9681efee5719e4c77db1389c48009f97d05
Submitter: Zuul
Branch:    master

commit 3daeb9681efee5719e4c77db1389c48009f97d05
Author: Sean McGinnis <sean.mcginnis@xxxxxxxxxx>
Date:   Sat Oct 7 13:49:57 2017 -0500

    Update libvirt volume drivers to use os-brick constants
    
    Most drivers had hard coded protocol strings, and one driver was using
    a constant from os-brick that has been deprecated for removal for quite
    some time.
    
    This updates all volume drivers to use the current available constants
    from os-brick.
    
    Change-Id: I8682804d2299db793c1e4397a07ff67608a8bda6
    Closes-bug: #1721993


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1721993

Title:
  libvirt volume drivers using deprecated os-brick constants

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Attempting to clean out some old constants that have been marked
  deprecated in os-brick for over a year. Job failures show there are
  some libvirt volume drivers still using the old constants.

  Traceback (most recent call last):
     File "/usr/local/bin/nova-compute", line 10, in <module>
       sys.exit(main())
     File "/opt/stack/new/nova/nova/cmd/compute.py", line 59, in main
       topic=compute_rpcapi.RPC_TOPIC)
     File "/opt/stack/new/nova/nova/service.py", line 258, in create
       periodic_interval_max=periodic_interval_max)
     File "/opt/stack/new/nova/nova/service.py", line 127, in __init__
       self.manager = manager_class(host=self.host, *args, **kwargs)
     File "/opt/stack/new/nova/nova/compute/manager.py", line 535, in __init__
       self.driver = driver.load_compute_driver(self.virtapi, compute_driver)
     File "/opt/stack/new/nova/nova/virt/driver.py", line 1609, in load_compute_driver
       virtapi)
     File "/usr/local/lib/python2.7/dist-packages/oslo_utils/importutils.py", line 44, in import_object
       return import_class(import_str)(*args, **kwargs)
     File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 337, in __init__
       self.volume_drivers = self._get_volume_drivers()
     File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 395, in _get_volume_drivers
       driver_registry[driver_type] = driver_class(self._host)
     File "/opt/stack/new/nova/nova/virt/libvirt/volume/drbd.py", line 29, in __init__
       connector.DRBD, utils.get_root_helper())
   AttributeError: 'module' object has no attribute 'DRBD'

  
  These just need to be updated to point to the new constants.

  This change was done is os-brick 1.6.0. All the way back to Newton,
  our minimum for os-brick is 1.6.2, so should be safe to remove the old
  constants and use the new ones.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1721993/+subscriptions