yahoo-eng-team team mailing list archive

[Akihiro Motoki <1115692@xxxxxxxxxxxxxxxxxx>]

The workflow template has been improved and the reported issue has been
addressed, so Invalid.

** Changed in: horizon
     Assignee: Gabriel Hurley (gabriel-hurley) => (unassigned)

** Changed in: horizon
       Status: Confirmed => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1115692

Title:
  Move dashboard workflow templates into common

Status in OpenStack Dashboard (Horizon):
  Invalid

Bug description:
  All the workflow templates are identical except for the title. We can
  move this template into common and replace the title with {{
  workflow.name }}.

  kspear@kspear:~/openstack/horizon/openstack_dashboard/dashboards$ grep -r _workflow.html * | cut -d: -f1
  admin/projects/templates/projects/update.html
  admin/projects/templates/projects/create.html
  admin/networks/templates/networks/subnets/update.html
  admin/networks/templates/networks/subnets/create.html
  project/access_and_security/templates/access_and_security/floating_ips/associate.html
  project/instances/templates/instances/launch.html
  project/networks/templates/networks/subnets/update.html
  project/networks/templates/networks/subnets/create.html
  project/networks/templates/networks/create.html

  kspear@kspear:~/openstack/horizon/openstack_dashboard/dashboards$ grep -r _workflow.html * | cut -d: -f1 | xargs cat | sort | uniq
  {% block main %}
  {% block page_header %}
  {% block title %}Create Project{% endblock %}
  {% block title %}{% trans "Associate Floating IP" %}{% endblock %}
  {% block title %}{% trans "Create Network" %}{% endblock %}
  {% block title %}{% trans "Create Subnet" %}{% endblock %}
  {% block title %}{% trans "Edit Project" %}{% endblock %}
  {% block title %}{% trans "Launch Instance" %}{% endblock %}
  {% block title %}{% trans "Update Subnet" %}{% endblock %}
  {% endblock %}
  {% endblock page_header %}
  {% extends 'base.html' %}
    {% include "horizon/common/_page_header.html" with title=_("Associate Floating IP") %}
    {% include "horizon/common/_page_header.html" with title=_("Create Network") %}
    {% include "horizon/common/_page_header.html" with title=_("Create Project") %}
    {% include "horizon/common/_page_header.html" with title=_("Create Subnet") %}
    {% include "horizon/common/_page_header.html" with title=_("Edit Project") %}
    {% include "horizon/common/_page_header.html" with title=_("Launch Instance") %}
    {% include "horizon/common/_page_header.html" with title=_("Update Subnet") %}
    {% include 'horizon/common/_workflow.html' %}
    {% include "horizon/common/_workflow.html" %}
  {% load i18n %}

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1115692/+subscriptions