← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1331258] Re: workflow default success/error messaging bug

 

** Changed in: horizon
       Status: New => Invalid

** Changed in: horizon
     Assignee: David Cusatis (dcusati) => (unassigned)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1331258

Title:
  workflow default success/error messaging bug

Status in OpenStack Dashboard (Horizon):
  Invalid

Bug description:
  Default workflow success and failure messages are:

  success_message = _("%s completed successfully.")
  failure_message = _("%s did not complete.")
  https://github.com/openstack/horizon/blob/master/horizon/workflows/base.py#L595

  According to the class definition, failure message is supposed to be:
  "{{ workflow.name }} did not complete."

  However, it ends up using the row.name and appearing as "demo did not
  complete."

  When it should be "Edit project did not complete".

  Please see attachment.

  You can try this out for yourself by going to /admin/projects/workflows.py (https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/projects/workflows.py#L346)
  and commenting out the two success and failure messages.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1331258/+subscriptions


References