yahoo-eng-team team mailing list archive

[OpenStack Infra <1732077@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/519544
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=db4a83f8bcc786dba9b1eb4e69af45c46b0a333c
Submitter: Zuul
Branch:    master

commit db4a83f8bcc786dba9b1eb4e69af45c46b0a333c
Author: Pranali Deore <pdeore@xxxxxxxxxx>
Date:   Tue Nov 14 11:31:02 2017 +0530

    Removing unreachable line from stage() method
    
    In stage() method of v2 api, _restore() is called after raising
    HTTPConflict exception, which won't be reachable in any case after
    the exception is raised.
    
    _restore() changes the image_status from 'uploading' to 'queued'
    and  data staging would start from the beginning after new stage call
    with same image-id even though staging data has already been loaded
    to store.
    
    Hence it seems there is no point in keeping that _restore() incase of
    Duplicate exception is raised.
    
    Change-Id: I317587bc1ba6544b722a11ae217a5d1212c96ce2
    Closes-Bug: 1732077


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1732077

Title:
  Unreachable line need to be removed from stage() method of V2

Status in Glance:
  Fix Released

Bug description:
  In stage() method of v2 api, _restore() is called after the raising
  Duplicate exception [1] which won't be reachable in any case after the
  exception is raised.

  _restore() changes the image_status from 'uploading' to 'queued'
  and  data staging would start from the beginning after new stage call
  with same image-id even though staging data has already been loaded
  to store.
      
  Hence it seems there is no point in keeping that _restore() incase of
  Duplicate exception is raised.

  [1]:
  https://github.com/openstack/glance/blob/5d2ce20a9e31808d9e91dc5da4a124823f23ad09/glance/api/v2/image_data.py#L306

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1732077/+subscriptions