← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1736385] Re: placement is not being properly restarted in grenade (pike to master)

 

Reviewed:  https://review.openstack.org/525605
Committed: https://git.openstack.org/cgit/openstack-dev/grenade/commit/?id=b7dbc632b6a0fe2b625096b3a53576e746150b0a
Submitter: Zuul
Branch:    master

commit b7dbc632b6a0fe2b625096b3a53576e746150b0a
Author: Chris Dent <cdent@xxxxxxxxxxxxx>
Date:   Tue Dec 5 13:21:19 2017 +0000

    Shutdown placement at the end of the base run
    
    Placement API was not being shutdown at the end of the OLD target,
    thus when it was being started at the beginning of the NEW target it
    was not actually getting new code. A call to stop_placement is added.
    
    In addition, make sure placement is installed in upgrade.sh so that
    any new stuff is in place.
    
    The depends-on is to a devstack change which makes sure that
    lib/placement does not call remove_uwsgi_config when stop_placement is
    called. Without this, there's no config file for the
    devstack@placement-api systemd unit to run, and there is an immediate
    exit.
    
    Change-Id: I7f2158aeaef82a47e11c6e29675e542023fff4be
    Depends-On: Iee763adf7895145d97b184924896db3f1f48a015
    Closes-Bug: #1736385


** Changed in: grenade
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1736385

Title:
  placement is not being properly restarted in grenade (pike to master)

Status in devstack:
  In Progress
Status in grenade:
  Fix Released
Status in OpenStack Compute (nova):
  Opinion

Bug description:
  When the placement service is supposed to restart in grenade (pike to
  master) it doesn't actually restart:

  http://logs.openstack.org/93/385693/84/check/legacy-grenade-dsvm-
  neutron-multinode-live-
  migration/9fa93e0/logs/grenade.sh.txt.gz#_2017-12-05_00_08_01_111

  This leads to issues with new microversions not being available:

  http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Unacceptable%20version%20header%3A%201.14%5C%22

  This is a latent bug that was revealed, at least in part, by efried's
  (correct) changes in https://review.openstack.org/#/c/524263/

  It looks like a bad assumption is being made somewhere in the handling
  of the systemd unit files: a 'start' when it is already started is
  success, but does not restart (thus new code is not loaded).

  We can probably fix this by using the 'restart' command instead of
  'start':

   restart PATTERN...
             Restart one or more units specified on the command line. If the units are not running yet, they will be started.

  
  Adding grenade and devstack as relate projects as the fix is presumably in devstack itself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/devstack/+bug/1736385/+subscriptions


References