yahoo-eng-team team mailing list archive

[OpenStack Infra <1733649@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/531169
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=386ec26b3d24f5862f6f76e0124a4370f45080cf
Submitter: Zuul
Branch:    master

commit 386ec26b3d24f5862f6f76e0124a4370f45080cf
Author: Sławek Kapłoński <slawek@xxxxxxxxxxxx>
Date:   Thu Jan 4 15:51:01 2018 +0100

    [Fullstack] Change how DSCP marking packets are tested
    
    In fullstack test test_dscp_marking_packets two fake hosts are
    created, each of them has got one fake instance (called sender and
    receiver).
    Instance called "sender" sends ICMP packets to instance called
    "receiver". In receiver's namespace tcpdump process is spawned with
    filter to match only packets marked with specified DSCP value.
    After sender instance successfully pings receiver, tcpdump process
    is killed and stdout from it was examined to search logged ICMP
    packets which were send from sender's IP to receiver's IP address.
    That check was failing sometimes as is described in bug report.
    
    It was failing when tcpdump doesn't capture any packets so there was
    nothing on stdout from it. But even in such case tcpdump reports on
    stderr summary of packets and it was like below:
    
    0 packets captured
    6 packets received by filter
    0 packets dropped by kernel
    
    which means that packets matching our filter was received by tcpdump but
    were probably not processed yet. See [1] for more details.
    
    So this patch changes filter used in tcpdump and way how its output is
    checked.
    Now in filter expression there are added src and dst IP addresses also so
    it will match only packets send from sender instance to receiver instance.
    After that tcpdump's stderr output is examined with regex to check if
    line like:
    
    X packets received by filter
    
    is there and if X value is different than 0. If so, it means that
    tcpdump received packets with wanted DSCP mark and test should pass.
    
    [1] https://unix.stackexchange.com/a/29369
    
    Change-Id: Ia3522237dc787edb90d162ac4a5535ff5d2a03d5
    Closes-Bug: #1733649


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1733649

Title:
  fullstack
  neutron.tests.fullstack.test_qos.TestDscpMarkingQoSOvs.test_dscp_marking_packets
  (openflow-native) failure

Status in neutron:
  Fix Released

Bug description:
  Fullstack
  neutron.tests.fullstack.test_qos.TestDscpMarkingQoSOvs.test_dscp_marking_packets
  (openflow-native) fails sometimes like on:
  http://logs.openstack.org/71/520371/7/check/legacy-neutron-dsvm-
  fullstack/ad585a2/logs/testr_results.html.gz

  In neutron-server logs there are errors like:
  http://logs.openstack.org/71/520371/7/check/legacy-neutron-dsvm-fullstack/ad585a2/logs/dsvm-fullstack-logs/TestDscpMarkingQoSOvs.test_dscp_marking_packets_openflow-native_/neutron-server--2017-11-20--22-12-38-673206.txt.gz?level=TRACE

  in such case.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1733649/+subscriptions