← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1752301] [NEW] Project tags treats entire collection as a single tag

 

Public bug reported:

When backporting Debian stable/queens from release Sid to Stretch, an
issue where 3 unit tests were failing due to the entire project tags
collection being treated as a single tag was encountered[0].

It was later determined that the hybrid_property.expression
implementation was causing this issue[1]. When a quick change was pushed
up and tested, the issue appeared to be fixed[2].

The fix for this issue is to drop @hybrid_property usage for @property,
which removes the use of tags.expression. Project should always have
tags instantiated, so there is not a behavior difference, which is a
better fit for @property.


[0] http://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2018-02-27.log.html#t2018-02-27T11:23:30

[1] http://eavesdrop.openstack.org/irclogs/%23openstack-keystone
/%23openstack-keystone.2018-02-27.log.html#t2018-02-27T19:32:42

[2] http://eavesdrop.openstack.org/irclogs/%23openstack-keystone
/%23openstack-keystone.2018-02-27.log.html#t2018-02-27T21:24:34

** Affects: keystone
     Importance: High
     Assignee: Gage Hugo (gagehugo)
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1752301

Title:
  Project tags treats entire collection as a single tag

Status in OpenStack Identity (keystone):
  In Progress

Bug description:
  When backporting Debian stable/queens from release Sid to Stretch, an
  issue where 3 unit tests were failing due to the entire project tags
  collection being treated as a single tag was encountered[0].

  It was later determined that the hybrid_property.expression
  implementation was causing this issue[1]. When a quick change was
  pushed up and tested, the issue appeared to be fixed[2].

  The fix for this issue is to drop @hybrid_property usage for
  @property, which removes the use of tags.expression. Project should
  always have tags instantiated, so there is not a behavior difference,
  which is a better fit for @property.

  
  [0] http://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2018-02-27.log.html#t2018-02-27T11:23:30

  [1] http://eavesdrop.openstack.org/irclogs/%23openstack-keystone
  /%23openstack-keystone.2018-02-27.log.html#t2018-02-27T19:32:42

  [2] http://eavesdrop.openstack.org/irclogs/%23openstack-keystone
  /%23openstack-keystone.2018-02-27.log.html#t2018-02-27T21:24:34

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1752301/+subscriptions


Follow ups