yahoo-eng-team team mailing list archive

[OpenStack Infra <1752301@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/548399
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=94ef9458858506766149761b8f2a9961d6c9def6
Submitter: Zuul
Branch:    master

commit 94ef9458858506766149761b8f2a9961d6c9def6
Author: Gage Hugo <gagehugo@xxxxxxxxx>
Date:   Tue Feb 27 19:55:22 2018 +0000

    Remove @expression from tags
    
    This change makes tags a property of Project instead of a hybrid_property
    since we will always have a Project contain some list of tags.
    
    Change-Id: I1033321132cb3ec71bf94b8293cef91dfc6b8272
    Co-Authored-By: Morgan Fainberg <morgan.fainberg@xxxxxxxxx>
    Closes-Bug: #1752301


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1752301

Title:
  Project tags treats entire collection as a single tag

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  When backporting Debian stable/queens from release Sid to Stretch, an
  issue where 3 unit tests were failing due to the entire project tags
  collection being treated as a single tag was encountered[0].

  It was later determined that the hybrid_property.expression
  implementation was causing this issue[1]. When a quick change was
  pushed up and tested, the issue appeared to be fixed[2].

  The fix for this issue is to drop @hybrid_property usage for
  @property, which removes the use of tags.expression. Project should
  always have tags instantiated, so there is not a behavior difference,
  which is a better fit for @property.

  
  [0] http://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2018-02-27.log.html#t2018-02-27T11:23:30

  [1] http://eavesdrop.openstack.org/irclogs/%23openstack-keystone
  /%23openstack-keystone.2018-02-27.log.html#t2018-02-27T19:32:42

  [2] http://eavesdrop.openstack.org/irclogs/%23openstack-keystone
  /%23openstack-keystone.2018-02-27.log.html#t2018-02-27T21:24:34

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1752301/+subscriptions