yahoo-eng-team team mailing list archive

[lucky <1764332@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Unnecessarily use of a list and extra loop call to offload the shelved
instances whose shelved time passed the shelved offload time.

To offload the shelved instances whose shelved time passed the shelved
offload time, first list is created and then this list of shelved
instances is processed in extra loop. Instead of creating a list of
offload ready shelved instances and processing them later, same can be
done in one loop.


Code should be refactored. Instead of creating a list of offload ready shelved instances and processing them later, same can be done in one loop. Instances can be offloaded the time when their shelved time is checked. (Reference File: nova/compute/manger.py,  Function: _poll_shelved_instances, Line No: 5847)

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1764332

Title:
  Unnecessarily use of a list and extra loop call to offload the shelved
  instances whose shelved time passed the shelved offload time

Status in OpenStack Compute (nova):
  New

Bug description:
  Unnecessarily use of a list and extra loop call to offload the shelved
  instances whose shelved time passed the shelved offload time.

  To offload the shelved instances whose shelved time passed the shelved
  offload time, first list is created and then this list of shelved
  instances is processed in extra loop. Instead of creating a list of
  offload ready shelved instances and processing them later, same can be
  done in one loop.

  
  Code should be refactored. Instead of creating a list of offload ready shelved instances and processing them later, same can be done in one loop. Instances can be offloaded the time when their shelved time is checked. (Reference File: nova/compute/manger.py,  Function: _poll_shelved_instances, Line No: 5847)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1764332/+subscriptions