yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem.os@xxxxxxxxx>]

Well, wait. In looking at this, I assume it's done in two loops because
the first loop is time-sensitive in collecting the list of instances
that should be offloaded, the 2nd loop then offloads those instances
from the first loop. If we merge the loops, we could end up shelving
things that we might not before because the offload operation slides the
window. So I'm going to mark this as invalid.

** Changed in: nova
       Status: Triaged => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1764332

Title:
  Unnecessarily use of a list and extra loop call to offload the shelved
  instances whose shelved time passed the shelved offload time

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  Unnecessarily use of a list and extra loop call to offload the shelved
  instances whose shelved time passed the shelved offload time.

  To offload the shelved instances whose shelved time passed the shelved
  offload time, first list is created and then this list of shelved
  instances is processed in extra loop. Instead of creating a list of
  offload ready shelved instances and processing them later, same can be
  done in one loop.

  
  Code should be refactored. Instead of creating a list of offload ready shelved instances and processing them later, same can be done in one loop. Instances can be offloaded the time when their shelved time is checked. (Reference File: nova/compute/manger.py,  Function: _poll_shelved_instances, Line No: 5847)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1764332/+subscriptions