yahoo-eng-team team mailing list archive

[OpenStack Infra <1622694@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/561461
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=f11b1a8b68cb2ef52d0c431cf37ff277f8d0438e
Submitter: Zuul
Branch:    master

commit f11b1a8b68cb2ef52d0c431cf37ff277f8d0438e
Author: Adit Sarfaty <asarfaty@xxxxxxxxxx>
Date:   Sun Apr 15 15:52:20 2018 +0300

    Remove firewall (v1) shared attribute from tests
    
    The V1 firewall object does not support 'shared' attribute.
    This patch removes this attribute from the unit tests, and delete
    the already skipped test test_update_firewall_shared_fails_for_non_admin
    which is irrelevant.
    
    Change-Id: Ib9091bba9a8a3f5c04562304477c20506b2c91dc
    Closes-Bug: #1622694


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1622694

Title:
  [FWaaS] Unit test race condition in creating/updating firewall

Status in neutron:
  Fix Released

Bug description:
  The FWaaS unit test
  neutron_fwaas.tests.unit.services.firewall.test_fwaas_plugin.TestFirewallPluginBase.test_update_firewall_shared_fails_for_non_admin
  creates a firewall, and then tries an update.  If that update occurs
  before the creation is completed, then the router is still in
  PENDING_UPDATE state and a successful return code is returned.  Since
  the test is expecting exc.HTTPForbidden.code (HTTP 403), this means
  the test fails.  This looks like a race condition, but it should be
  handled properly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1622694/+subscriptions