← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1767021] Re: Login form button text is inconsistent

 

Reviewed:  https://review.openstack.org/562104
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ad25568db970a68dcaa7958f957ce5e5b7a3044d
Submitter: Zuul
Branch:    master

commit ad25568db970a68dcaa7958f957ce5e5b7a3044d
Author: Adrian Turjak <adriant@xxxxxxxxxxxxxxx>
Date:   Wed Apr 18 15:22:20 2018 +1200

    Standardize the login form button text
    
    The default always seemed to be connect, potentially
    due to a bug. This just gets rid of the connect option
    and makes 'sign in' the only text.
    
    Closes-bug: #1767021
    Change-Id: I77830ddb24616742abe691b45f89b8c9eb18aff9


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1767021

Title:
  Login form button text is inconsistent

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The login form button appears to be by default 'connect', which does
  not really match the common text for such a button.

  'Log in' or 'Sign in' are more common, and it appears the code
  technically should show 'Sign in' under some circumstances
  (auth_type==='credentials').

  I don't know in what context 'Connect' is ever actually appropriate,
  and I think we should just stick with 'Sign in' as the only text here.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1767021/+subscriptions


References