← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1766053] Re: Need to drop "Flavor Edit" step in "Modify Access" form

 

Reviewed:  https://review.openstack.org/563586
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=70b9d258bd647d2829d5e58bbee4cda01f3da183
Submitter: Zuul
Branch:    master

commit 70b9d258bd647d2829d5e58bbee4cda01f3da183
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Sun Apr 22 18:55:52 2018 +0900

    Drop Flavor Edit completely
    
    After dropping the flavor edit feature was dropped in Rocky-1,
    we still allow to edit flavor in the "Modify Access" form.
    This commit drops the remaining flavor edit forms.
    
    Duplicated API calls (flavor_get and flavor_access_list)
    in the UpdateFlavorAccess form are refactored into one API
    call per request.
    
    Change-Id: I009fe285d2263fd9b9f07ed1c3f4c96df261b535
    Closes-Bug: #1766053


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1766053

Title:
  Need to drop "Flavor Edit" step in "Modify Access" form

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  "Edit Flavor" feature was dropped in Rocky-1, but the edit flavor
  feature still exists in "Flavor Edit" step in "Modify Access"
  workflow.

  - Go to Admin -> Flavors
  - Open "Modify Access" action (for private flavors)
  - You can find "Flavor Information" step in the opened form

  UpdateFlavor.handle() in
  openstack_dashboard/dashboards/admin/flavors/workflows.py tries to re-
  create (delete and create) a corresponding flavor. This behavior
  should be dropped as "Edit Flavor" removal.

  Note that private flavors (with is_public False) is needed to open
  this form.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1766053/+subscriptions


References