yahoo-eng-team team mailing list archive

[Jay Pipes <1770636@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Something I noticed while reviewing
https://review.openstack.org/#/c/546675/14/osc_placement/resources/resource_provider.py
is that the code that prevents parent providers from being deleted:

https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/objects/resource_provider.py#L970

raises a CannotDeleteParentResourceProvider exception, but we're not
catching that in the handler:

https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/resource_provider.py#L130-L140

Need to add a gabbit func test and catch that exception properly,
converting it to an HTTP 409 Conflict.

** Affects: nova
     Importance: Low
         Status: Triaged


** Tags: low-hanging-fruit placement

** Tags added: low-hanging-fruit

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1770636

Title:
  placement API not translating CannotDeleteParentResourceProvider to
  409 Conflict

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  Something I noticed while reviewing
  https://review.openstack.org/#/c/546675/14/osc_placement/resources/resource_provider.py
  is that the code that prevents parent providers from being deleted:

  https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/objects/resource_provider.py#L970

  raises a CannotDeleteParentResourceProvider exception, but we're not
  catching that in the handler:

  https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/resource_provider.py#L130-L140

  Need to add a gabbit func test and catch that exception properly,
  converting it to an HTTP 409 Conflict.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1770636/+subscriptions