yahoo-eng-team team mailing list archive

[OpenStack Infra <1770636@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/577726
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1ea3d5ec743838ddb754739a9919a2ecf4c54f9f
Submitter: Zuul
Branch:    master

commit 1ea3d5ec743838ddb754739a9919a2ecf4c54f9f
Author: deepak.mourya <deepak.mourya@xxxxxxxxxxxxxxxxxx>
Date:   Mon Jun 25 10:05:38 2018 +0530

    Handle CannotDeleteParentResourceProvider to 409 Conflict
    
    Error handling to raise the exception 409 while deleting
    the parent if it has children.
    
    Closes-Bug: #1770636
    Change-Id: I87df68992e4e635f009974f5205ca4919a4f2576


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1770636

Title:
  placement API not translating CannotDeleteParentResourceProvider to
  409 Conflict

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Something I noticed while reviewing
  https://review.openstack.org/#/c/546675/14/osc_placement/resources/resource_provider.py
  is that the code that prevents parent providers from being deleted:

  https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/objects/resource_provider.py#L970

  raises a CannotDeleteParentResourceProvider exception, but we're not
  catching that in the handler:

  https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/resource_provider.py#L130-L140

  Need to add a gabbit func test and catch that exception properly,
  converting it to an HTTP 409 Conflict.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1770636/+subscriptions