← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1772523] [NEW] Placement request filters are run on rebuild even though we don't call placement

 

Public bug reported:

Any enabled placement request filters are processed during scheduling
here:

https://github.com/openstack/nova/blob/d78055df0e39b53fd481c53429ba77f8c1e1ab09/nova/scheduler/manager.py#L127

But then if we're doing a rebuild, we don't call placement:

https://github.com/openstack/nova/blob/d78055df0e39b53fd481c53429ba77f8c1e1ab09/nova/scheduler/manager.py#L132

https://github.com/openstack/nova/blob/d78055df0e39b53fd481c53429ba77f8c1e1ab09/nova/scheduler/manager.py#L135

So we're unnecessarily processing the request spec filters (like
querying the aggregates table) just to throw the results away on
rebuild.

** Affects: nova
     Importance: Medium
         Status: Triaged


** Tags: low-hanging-fruit performance placement rebuild scheduler

** Tags added: low-hanging-fruit

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1772523

Title:
  Placement request filters are run on rebuild even though we don't call
  placement

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  Any enabled placement request filters are processed during scheduling
  here:

  https://github.com/openstack/nova/blob/d78055df0e39b53fd481c53429ba77f8c1e1ab09/nova/scheduler/manager.py#L127

  But then if we're doing a rebuild, we don't call placement:

  https://github.com/openstack/nova/blob/d78055df0e39b53fd481c53429ba77f8c1e1ab09/nova/scheduler/manager.py#L132

  https://github.com/openstack/nova/blob/d78055df0e39b53fd481c53429ba77f8c1e1ab09/nova/scheduler/manager.py#L135

  So we're unnecessarily processing the request spec filters (like
  querying the aggregates table) just to throw the results away on
  rebuild.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1772523/+subscriptions


Follow ups