yahoo-eng-team team mailing list archive

[OpenStack Infra <1772523@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/569969
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=036fb56ab3779ebb37804487aecbfaa69e764b3b
Submitter: Zuul
Branch:    master

commit 036fb56ab3779ebb37804487aecbfaa69e764b3b
Author: Kevin_Zheng <zhengzhenyu@xxxxxxxxxx>
Date:   Tue May 22 20:00:16 2018 +0800

    Only run placement request filters when Placement will be called
    
    Any enabled placement request filters are processed during scheduling
    here:
    
    https://github.com/openstack/nova/blob/d78055/nova/scheduler/manager.py#L127
    
    But then if we're doing a rebuild, or the driver.USES_ALLOCATION_CANDIDATES
    is False, we don't call placement:
    
    https://github.com/openstack/nova/blob/d78055/nova/scheduler/manager.py#L132
    
    https://github.com/openstack/nova/blob/d78055/nova/scheduler/manager.py#L135
    
    So we're unnecessarily processing the request spec filters (like
    querying the aggregates table) in those conditions.
    
    Change-Id: I8ed019c2208c28bb733aac961e855ce77f332a1e
    Closes-bug: #1772523


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1772523

Title:
  Placement request filters are run on rebuild even though we don't call
  placement

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Any enabled placement request filters are processed during scheduling
  here:

  https://github.com/openstack/nova/blob/d78055df0e39b53fd481c53429ba77f8c1e1ab09/nova/scheduler/manager.py#L127

  But then if we're doing a rebuild, we don't call placement:

  https://github.com/openstack/nova/blob/d78055df0e39b53fd481c53429ba77f8c1e1ab09/nova/scheduler/manager.py#L132

  https://github.com/openstack/nova/blob/d78055df0e39b53fd481c53429ba77f8c1e1ab09/nova/scheduler/manager.py#L135

  So we're unnecessarily processing the request spec filters (like
  querying the aggregates table) just to throw the results away on
  rebuild.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1772523/+subscriptions