yahoo-eng-team team mailing list archive

[OpenStack Infra <1469179@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/583715
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9344c1995a059675af7a8e9cf0de0502bef46c94
Submitter: Zuul
Branch:    master

commit 9344c1995a059675af7a8e9cf0de0502bef46c94
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Wed Jul 18 13:13:45 2018 -0400

    Heal RequestSpec.is_bfv for legacy instances during moves
    
    Change I9c2111f7377df65c1fc3c72323f85483b3295989 sets the
    RequestSpec.is_bfv flag for newly created instances so
    that scheduling (using placement) does not allocate DISK_GB
    resources for the Flavor's root_gb when booting from volume.
    
    RequestSpecs for old instances created before that change will
    not have the is_bfv field set, so this change adds a check for
    that in the various move operations (evacuate, unshelve, cold
    migrate and live migrate) and sets the RequestSpec.is_bfv flag
    accordingly.
    
    The related functional test is updated for the legacy cold
    migrate and heal scenario.
    
    Change-Id: I8e529ad4d707b2ad012328993892db83ce464c4b
    Closes-Bug: #1469179


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1469179

Title:
  instance.root_gb should be 0 for volume-backed instances

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  instance.root_gb means size of host local disk used by the instance
  root disk. All code that uses this attribute treats it that way.

  Volume-backed instances have root disks placed in Cinder. Therefore
  obviously root_gb should be 0 for them. However currently this is not
  so. The same applies to min_disk and size image attributes, used for
  boot from a volume.

  As a result the code which uses these attributes works incorrectly.
  Some problems are already detected [1], other are not yet [2].

  There are two kinds of bugs:
  1 Nova fails to launch an instance from a large volume if the volume size (or an original image's min_disk) is greater than requested flavor.root_gb.
  2 Nova incorrectly calculates host disk space consumed by volume-backed instances.

  To fix all these problems fully it is proposed to set root_gb,
  min_disk, size to 0 for volume-backed instances.

  [1] https://bugs.launchpad.net/nova/+bug/1334974
  https://bugs.launchpad.net/nova/+bug/1459491
  https://bugs.launchpad.net/nova/+bug/1466305
  https://bugs.launchpad.net/nova/+bug/1457517
  https://bugs.launchpad.net/nova/+bug/1358566
  [2] https://github.com/openstack/nova/blob/master/nova/notifications.py#L407
  https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L250

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1469179/+subscriptions