yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #74473
[Bug 1787331] Re: The eventlet.monkey_patch is not valid under uwsgi mode
Reviewed: https://review.openstack.org/592285
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=23ba1c690652832c655d57476630f02c268c87ae
Submitter: Zuul
Branch: master
commit 23ba1c690652832c655d57476630f02c268c87ae
Author: Yikun Jiang <yikunkero@xxxxxxxxx>
Date: Thu Aug 16 14:29:26 2018 +0800
Make monkey patch work in uWSGI mode
There was a eventlet.monkey_patch [1] when we launch a nova
process(like nova-api, nova-compute), but it's invalid under
the uwsgi mode.
But there are concurrency requirements in the api service, such
as, when listing instances cross multiple cells we're using
greenthreads and oslo.db does a time.sleep to allow switching
greenthreads [2].
So, in this patch we add the monkey_patch in the uwsgi
application setup and refactor the monkey patching to use common
code.
[1] https://github.com/openstack/nova/blob/233ea58/nova/cmd/__init__.py#L26
[2] https://github.com/openstack/oslo.db/blob/9c66959/oslo_db/sqlalchemy/engines.py#L51
Closes-bug: #1787331
Change-Id: Ie7bf5d012e2ccbcd63c262ddaf739782afcdaf56
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1787331
Title:
The eventlet.monkey_patch is not valid under uwsgi mode
Status in OpenStack Compute (nova):
Fix Released
Bug description:
There was a eventlet.monkey_patch [1] when we launch a nova
process(like nova-api, nova-compute), but it's invalid under the uwsgi
mode.
So, we need do same monkey_patch when we setup uwsgi appilication.
[1]
https://github.com/openstack/nova/blob/233ea58/nova/cmd/__init__.py#L26
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1787331/+subscriptions
References