yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem.os@xxxxxxxxx>]

Public bug reported:

Nova change https://review.openstack.org/#/c/317693/ set a min=1 value
on the shutdown_timeout config option.

https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.shutdown_timeout

The glance image meta def description for the related
os_shutdown_timeout property says it can be 0 to make the guest
immediately shutdown:

https://github.com/openstack/glance/blob/48ee8ef4793ed40397613193f09872f474c11abe/etc/metadefs
/compute-guest-shutdown.json#L13

"By default, guests will be given 60 seconds to perform a graceful
shutdown. After that, the VM is powered off.  This property allows
overriding the amount of time (unit: seconds) to allow a guest OS to
cleanly shut down before power off. A value of 0 (zero) means the guest
will be powered off immediately with no opportunity for guest OS clean-
up."

Looking at the actual compute manager code that deals with this config
option (and image property), it should be able to allow 0 to match when
a clean shutdown is not being performed:

https://github.com/openstack/nova/blob/835faf3f40af6b0e07c585690982a997d6a2ac47/nova/compute/manager.py#L2423

** Affects: nova
     Importance: Low
     Assignee: Matt Riedemann (mriedem)
         Status: In Progress


** Tags: compute config

** Changed in: nova
     Assignee: (unassigned) => Matt Riedemann (mriedem)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1799707

Title:
  shutdown_timeout config min version is not consistent with glance
  image meta def

Status in OpenStack Compute (nova):
  In Progress

Bug description:
  Nova change https://review.openstack.org/#/c/317693/ set a min=1 value
  on the shutdown_timeout config option.

  https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.shutdown_timeout

  The glance image meta def description for the related
  os_shutdown_timeout property says it can be 0 to make the guest
  immediately shutdown:

  https://github.com/openstack/glance/blob/48ee8ef4793ed40397613193f09872f474c11abe/etc/metadefs
  /compute-guest-shutdown.json#L13

  "By default, guests will be given 60 seconds to perform a graceful
  shutdown. After that, the VM is powered off.  This property allows
  overriding the amount of time (unit: seconds) to allow a guest OS to
  cleanly shut down before power off. A value of 0 (zero) means the
  guest will be powered off immediately with no opportunity for guest OS
  clean-up."

  Looking at the actual compute manager code that deals with this config
  option (and image property), it should be able to allow 0 to match
  when a clean shutdown is not being performed:

  https://github.com/openstack/nova/blob/835faf3f40af6b0e07c585690982a997d6a2ac47/nova/compute/manager.py#L2423

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1799707/+subscriptions