yahoo-eng-team team mailing list archive

[OpenStack Infra <1799707@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/613028
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2cff865af4a36c200a7b1737929b7e0595325478
Submitter: Zuul
Branch:    master

commit 2cff865af4a36c200a7b1737929b7e0595325478
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Wed Oct 24 09:44:09 2018 -0400

    Fix min config value for shutdown_timeout option
    
    The shutdown_timeout config option was added in commit
    c07ed15415c0ec3c5862f437f440632eff1e94df without a min
    value. The min value was later added in commit
    d67ea6e5549086eee1b39946648410f22d0041a9 and set to 1,
    which means the option can never be configured to mean
    "always immediately shutdown". That is also inconsistent
    with the description of the "os_shutdown_timeout" image
    property in the glance metadata definition which says the
    value can be set to 0 to force an immediate shutdown of
    the guest.
    
    This fixes the min value in the config option to be 0 which
    is already what happens if we are not performing a clean
    shutdown at all.
    
    Change-Id: I399b9031d2aa477194697390e2cd3f78e3ac0f91
    Closes-Bug: #1799707


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1799707

Title:
  shutdown_timeout config min version is not consistent with glance
  image meta def

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Nova change https://review.openstack.org/#/c/317693/ set a min=1 value
  on the shutdown_timeout config option.

  https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.shutdown_timeout

  The glance image meta def description for the related
  os_shutdown_timeout property says it can be 0 to make the guest
  immediately shutdown:

  https://github.com/openstack/glance/blob/48ee8ef4793ed40397613193f09872f474c11abe/etc/metadefs
  /compute-guest-shutdown.json#L13

  "By default, guests will be given 60 seconds to perform a graceful
  shutdown. After that, the VM is powered off.  This property allows
  overriding the amount of time (unit: seconds) to allow a guest OS to
  cleanly shut down before power off. A value of 0 (zero) means the
  guest will be powered off immediately with no opportunity for guest OS
  clean-up."

  Looking at the actual compute manager code that deals with this config
  option (and image property), it should be able to allow 0 to match
  when a clean shutdown is not being performed:

  https://github.com/openstack/nova/blob/835faf3f40af6b0e07c585690982a997d6a2ac47/nova/compute/manager.py#L2423

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1799707/+subscriptions