yahoo-eng-team team mailing list archive

[OpenStack Infra <1803723@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/619286
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=2a7994851cc0767e6a7b192a4101e8b43681ae6a
Submitter: Zuul
Branch:    master

commit 2a7994851cc0767e6a7b192a4101e8b43681ae6a
Author: Édouard Thuleau <ethuleau@xxxxxxxxxxx>
Date:   Wed Nov 21 16:56:07 2018 +0100

    Move port validation support into the driver
    
    Each firewall driver have specific checks to do on port validation (like
    checks if the VIF port type corresponds to a type supported by the driver
    (aka the SDN controller)). This patch adds two methods to the driver
    interface to validate if the VM or the router port is supported (just
    have to return a boolean).
    
    Change-Id: I8fdf0956ac5428558aae413e610d13c4a4a56273
    Closes-Bug: #1803723


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1803723

Title:
  [fwaas] _is_supported_by_fw_l2_driver method is hard linked to the
  default ML2/OVS core plugin implementation

Status in neutron:
  Fix Released

Bug description:
  The Neutron FWaaS service plugin validate Neutron port properties
  before it allows to add a firewall group to it thanks to twhich does
  not allow other port type to works with the FWaaS.

  IMO, that check needs to be done by the driver, furthermore for the
  ML2/OVS case by the agent driver.

  [1] https://github.com/openstack/neutron-
  fwaas/blob/master/neutron_fwaas/services/firewall/fwaas_plugin_v2.py#L178

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1803723/+subscriptions