← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1806053] Re: APITestCase still needs to be patched utils.patch_middleware_get_user()

 

Reviewed:  https://review.openstack.org/621186
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=de69edd0402146d76c65cec6cc7879c71259fbbf
Submitter: Zuul
Branch:    master

commit de69edd0402146d76c65cec6cc7879c71259fbbf
Author: Ivan Kolodyazhny <e0ne@xxxxxxxxx>
Date:   Fri Nov 30 17:33:21 2018 +0200

    Add Fix django.contrib.auth.middleware monkey patching for APITestCase
    
    This patch rollbacks changes in APITestCase introduced in the
    0d163613265e036818fe567793a4fc88fe140d4a commit to unblock Horizon
    plugins gates.
    
    Change-Id: I6b2be31568e4aa4273990f9cfa76ca139620c84b
    Closes-bug: #1806053
    Closes-bug: #1805240


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1806053

Title:
  APITestCase still needs to be patched
  utils.patch_middleware_get_user()

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  After merging commit 0d163613265e036818fe567793a4fc88fe140d4a, we see
  some UT breakage in horizon plugins.

  bgpvpn-dashboard https://bugs.launchpad.net/bgpvpn/+bug/1805240
  neutron-fwaas-dashboard https://review.openstack.org/621155
  neutron-vpnaas-dashboard https://review.openstack.org/621152

  Previously APITestCase called patch_middleware_get_user explicitly,
  but the commit above dropped it. This seems to trigger the above UT
  failures.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1806053/+subscriptions


References