yahoo-eng-team team mailing list archive

[OpenStack Infra <1804900@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/619807
Committed: https://git.openstack.org/cgit/openstack/nova-specs/commit/?id=0c0004c1fa593319c99d7ff10d4b72ef5a834f8d
Submitter: Zuul
Branch:    master

commit 0c0004c1fa593319c99d7ff10d4b72ef5a834f8d
Author: Andreas Karis <akaris@xxxxxxxxxx>
Date:   Fri Nov 23 18:49:16 2018 -0500

    Remove doc about metadata from 'share-pci-between-numa-nodes'
    
    Removing any reference to image and flavor metadata from the
    documentation
    
    Change-Id: I502701f3f62390da291f04b09394b607c9a0bfc1
    Closes-Bug: 1804900


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1804900

Title:
  share-pci-between-numa-nodes.html implemented spec for Queens still
  contains reference to image and flavor metadata

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  share-pci-between-numa-nodes.html implemented spec for Queens still contains reference to image and flavor metadata
  ----------------------
  Note that https://review.openstack.org/#/q/topic:bp/share-pci-between-numa-nodes links to [Update 'share-pci-between-numa-nodes' spec to reflect reality](https://review.openstack.org/#/c/555000/)

  With description:
  ~~~
  Update 'share-pci-between-numa-nodes' spec to reflect reality Upon implementation, the per-device configuration was deemed preferable to adding yet more image metadata and flavor extra spec keys. Update the spec to reflect this change. 
  ~~~

  However, the spec seems to have omitted that there is a section still
  talking about image and flavor metadata:

  https://review.openstack.org/#/c/555000/3/specs/queens/implemented/share-pci-between-numa-nodes.rst
  https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/share-pci-between-numa-nodes.html
  ~~~
  If both image and flavor properties are not set (equals ``None``) the
  ``legacy`` policy will be used. If one of image *or* flavor property is not set
  (equals ``None``) but the other property is set then the value of the set
  property will be used. In a case of conflicts between flavor and image
  properties (both properties are set and they are not equal) an exception will
  be raised.

  The end result will be an option that looks something like this::

      [pci]
      alias = '{
        "name": "QuickAssist",
        "product_id": "0443",
        "vendor_id": "8086",
        "device_type": "type-PCI",
        "numa_policy": "legacy"
      }'
  ~~~

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1804900/+subscriptions