← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1811181] Re: In the form to add an interface in router, when we do not select subnet, no error message is shown

 

Reviewed:  https://review.opendev.org/629755
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f62349a92bd90e913d5d56273cc542469216bf65
Submitter: Zuul
Branch:    master

commit f62349a92bd90e913d5d56273cc542469216bf65
Author: pengyuesheng <pengyuesheng@xxxxxxxxxxxxx>
Date:   Thu Jan 10 11:26:29 2019 +0800

    Add use_required_attribute = False in Add Interface Form
    
    When an element is required and hidden,
    the browser will report an error when submitting the form.
    
    Here is the code location where Django adds the required attribute to the element:
    https://github.com/django/django/blob/master/django/forms/boundfield.py#L221-L222
    
    Change-Id: I68e1145efbe1837861aa1d66fceec497d6d97cb9
    Closes-Bug: #1811181


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1811181

Title:
  In the form to add an interface in router, when we do not select
  subnet, no error message is shown

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Error message:An invalid form control with name='subnet_id' is not
  focusable

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1811181/+subscriptions


References