yahoo-eng-team team mailing list archive

[Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>]

** Also affects: nova/stein
   Importance: Undecided
       Status: New

** Also affects: nova/ocata
   Importance: Undecided
       Status: New

** Also affects: nova/pike
   Importance: Undecided
       Status: New

** Also affects: nova/rocky
   Importance: Undecided
       Status: New

** Also affects: nova/queens
   Importance: Undecided
       Status: New

** Changed in: nova/ocata
     Assignee: (unassigned) => Takashi NATSUME (natsume-takashi)

** Changed in: nova/pike
     Assignee: (unassigned) => Takashi NATSUME (natsume-takashi)

** Changed in: nova/queens
     Assignee: (unassigned) => Takashi NATSUME (natsume-takashi)

** Changed in: nova/rocky
     Assignee: (unassigned) => Takashi NATSUME (natsume-takashi)

** Changed in: nova/stein
     Assignee: (unassigned) => Takashi NATSUME (natsume-takashi)

** Changed in: nova/ocata
   Importance: Undecided => Medium

** Changed in: nova/pike
   Importance: Undecided => Medium

** Changed in: nova/queens
   Importance: Undecided => Medium

** Changed in: nova/rocky
   Importance: Undecided => Medium

** Changed in: nova/stein
   Importance: Undecided => Medium

** Changed in: nova/ocata
       Status: New => Confirmed

** Changed in: nova/pike
       Status: New => Confirmed

** Changed in: nova/queens
       Status: New => Confirmed

** Changed in: nova/rocky
       Status: New => Confirmed

** Changed in: nova/stein
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1839853

Title:
  Misuse of nova.objects.base.obj_equal_prims in tests

Status in OpenStack Compute (nova):
  In Progress
Status in OpenStack Compute (nova) ocata series:
  Confirmed
Status in OpenStack Compute (nova) pike series:
  Confirmed
Status in OpenStack Compute (nova) queens series:
  Confirmed
Status in OpenStack Compute (nova) rocky series:
  Confirmed
Status in OpenStack Compute (nova) stein series:
  Confirmed

Bug description:
  There are some tests, mostly related to BuildRequest objects, that are
  calling nova.objects.base.obj_equal_prims which does not assert
  anything, it only returns True or False - the test code itself must
  assert the expected result of the obj_equal_prims method.

  https://github.com/openstack/nova/blob/ab34c941be28f3486cd2699af8d9237e9edac351/nova/tests/functional/db/test_build_request.py

  https://github.com/openstack/nova/blob/d89579a66ac38fd1e30cea55306e6e7b69bab5b9/nova/tests/unit/objects/test_build_request.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1839853/+subscriptions