yahoo-eng-team team mailing list archive

[OpenStack Infra <1839853@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/676030
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5c1d9dcbb29f5a84d56c4e496b3111b4040cad13
Submitter: Zuul
Branch:    master

commit 5c1d9dcbb29f5a84d56c4e496b3111b4040cad13
Author: Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>
Date:   Tue Aug 13 09:31:32 2019 +0900

    Fix misuse of nova.objects.base.obj_equal_prims
    
    The nova.objects.base.obj_equal_prims returns True or False.
    It does not assert anything.
    So the return value should be asserted in tests.
    
    Add assertTrue where the nova.objects.base.obj_equal_prims is called.
    
    Change-Id: I49460ec3b572ee14b32229e771a5499ff91e8722
    Closes-Bug: #1839853


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1839853

Title:
  Misuse of nova.objects.base.obj_equal_prims in tests

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) ocata series:
  Confirmed
Status in OpenStack Compute (nova) pike series:
  Confirmed
Status in OpenStack Compute (nova) queens series:
  Confirmed
Status in OpenStack Compute (nova) rocky series:
  Confirmed
Status in OpenStack Compute (nova) stein series:
  Confirmed

Bug description:
  There are some tests, mostly related to BuildRequest objects, that are
  calling nova.objects.base.obj_equal_prims which does not assert
  anything, it only returns True or False - the test code itself must
  assert the expected result of the obj_equal_prims method.

  https://github.com/openstack/nova/blob/ab34c941be28f3486cd2699af8d9237e9edac351/nova/tests/functional/db/test_build_request.py

  https://github.com/openstack/nova/blob/d89579a66ac38fd1e30cea55306e6e7b69bab5b9/nova/tests/unit/objects/test_build_request.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1839853/+subscriptions