yahoo-eng-team team mailing list archive

[OpenStack Infra <1735009@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/523559
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1819718e798fb904644391badc3beb40c181ac39
Submitter: Zuul
Branch:    master

commit 1819718e798fb904644391badc3beb40c181ac39
Author: Mathieu Gagné <mgagne@xxxxxxxx>
Date:   Mon Nov 27 17:33:50 2017 -0500

    Fix rebuild of baremetal instance when vm_state is ERROR
    
    Nova allows rebuild of instance when vm_state is ERROR. [1]
    
    The vm_state is restored to ACTIVE only after a successful build.
    This means rebuilding a baremetal instance using the Ironic driver
    is impossible because wait_for_active fails if vm_state=ERROR is found.
    
    This is a regression introduced in a previous change which added
    the ability to delete an instance in spawning state. [2]
    
    This present change will skip the abort installation logic
    if task_state is REBUILD_SPAWNING while preserving the previous logic.
    
    [1] https://bugs.launchpad.net/nova/+bug/1183946
    [2] https://bugs.launchpad.net/nova/+bug/1455000
    
    Change-Id: I857ad7264f1a7ef1263d8a9d4eca491d6c8dce0f
    Closes-bug: #1735009


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1735009

Title:
  Cannot rebuild baremetal instance when vm_state is ERROR

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) ocata series:
  New
Status in OpenStack Compute (nova) pike series:
  New
Status in OpenStack Compute (nova) queens series:
  New
Status in OpenStack Compute (nova) rocky series:
  New
Status in OpenStack Compute (nova) stein series:
  New

Bug description:
  You can rebuild an instance in ERROR since Havana:
  http://git.openstack.org/cgit/openstack/nova/commit/?id=99c51e34230394cadf0b82e364ea10c38e193979

  This change broke this feature for Ironic since Liberty:
  http://git.openstack.org/cgit/openstack/nova/commit/?id=ea3967a1fb47297608defd680286fd9051ff5bbe

  The change adds a check for vm_state=ERROR when waiting for baremetal
  instance to be ACTIVE.

  The vm_state is restored to ACTIVE only restored after a successful
  build. This means rebuilding a baremetal instance using the Ironic
  driver is impossible because wait_for_active fails if vm_state=ERROR
  is found.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1735009/+subscriptions