yahoo-eng-team team mailing list archive

[Darragh O'Reilly <1853582@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The help for ovs_all_ports says that when False, only ports that were
created by Neutron are deleted.

https://github.com/openstack/neutron/blob/67b613b795416406fb4fab143b3ec9ba8657711f/neutron/conf/agent/cmd.py#L41-L46
    cfg.BoolOpt('ovs_all_ports',
                default=False,
                help=_('True to delete all ports on all the OpenvSwitch '
                       'bridges. False to delete ports created by '
                       'Neutron on integration and external network '
                       'bridges.'))


But actually ports created by Nova are also deleted. Those also have the iface-id and attached-mac fields.
https://github.com/openstack/neutron/blob/67b613b795416406fb4fab143b3ec9ba8657711f/neutron/agent/ovsdb/impl_idl.py#L80-L81


# ovs-vsctl --columns=name,external_ids --format=table list Interface
name             external_ids                                                                                                                                            
---------------- ---------------------------------------------------------------------------------
...
"qr-868ef235-bb" {attached-mac="fa:16:3e:bb:94:ca", iface-id="868ef235-bba4-4776-aac9-4b46a9a17def", iface-status=active}
...
"qvof43ccb24-99" {attached-mac="fa:16:3e:70:5c:b0", iface-id="f43ccb24-999e-4f9d-a9e4-07d11b9e5128", iface-status=active, vm-uuid="33c6fffa-f58b-4aab-b5ba-9960c1e02004"}


Not sure which is wrong, the help or the script. Is it supposed to delete ports that were created by nova?

** Affects: neutron
     Importance: Undecided
         Status: New


** Tags: ovs

** Tags added: ovs

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1853582

Title:
  ovs cleanup deletes nova ports

Status in neutron:
  New

Bug description:
  The help for ovs_all_ports says that when False, only ports that were
  created by Neutron are deleted.

  https://github.com/openstack/neutron/blob/67b613b795416406fb4fab143b3ec9ba8657711f/neutron/conf/agent/cmd.py#L41-L46
      cfg.BoolOpt('ovs_all_ports',
                  default=False,
                  help=_('True to delete all ports on all the OpenvSwitch '
                         'bridges. False to delete ports created by '
                         'Neutron on integration and external network '
                         'bridges.'))

  
  But actually ports created by Nova are also deleted. Those also have the iface-id and attached-mac fields.
  https://github.com/openstack/neutron/blob/67b613b795416406fb4fab143b3ec9ba8657711f/neutron/agent/ovsdb/impl_idl.py#L80-L81

  
  # ovs-vsctl --columns=name,external_ids --format=table list Interface
  name             external_ids                                                                                                                                            
  ---------------- ---------------------------------------------------------------------------------
  ...
  "qr-868ef235-bb" {attached-mac="fa:16:3e:bb:94:ca", iface-id="868ef235-bba4-4776-aac9-4b46a9a17def", iface-status=active}
  ...
  "qvof43ccb24-99" {attached-mac="fa:16:3e:70:5c:b0", iface-id="f43ccb24-999e-4f9d-a9e4-07d11b9e5128", iface-status=active, vm-uuid="33c6fffa-f58b-4aab-b5ba-9960c1e02004"}

  
  Not sure which is wrong, the help or the script. Is it supposed to delete ports that were created by nova?

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1853582/+subscriptions