yahoo-eng-team team mailing list archive

[OpenStack Infra <1853582@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/697439
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4075db5fd066715fd143201590092a1cf0bdf08a
Submitter: Zuul
Branch:    master

commit 4075db5fd066715fd143201590092a1cf0bdf08a
Author: Darragh O'Reilly <doreilly@xxxxxxxx>
Date:   Thu Dec 5 10:35:35 2019 +0000

    Improve ovs cleanup utility help
    
    Fixed a couple of things for ovs_all_ports=False.
    First state that it also cleans up ports created by Nova.
    Second since [1] it only cleans up the integration bridge.
    
    [1] https://opendev.org/openstack/neutron/commit/b09b4460
    
    Change-Id: I41dda554e8cb4b4ca36515d64f17ad5bf52f3b49
    Closes-Bug: #1853582


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1853582

Title:
  ovs_all_ports option used by ovs cleanup has a misleading help string

Status in neutron:
  Fix Released

Bug description:
  The help for ovs_all_ports says that when False, only ports that were
  created by Neutron are deleted.

  https://github.com/openstack/neutron/blob/67b613b795416406fb4fab143b3ec9ba8657711f/neutron/conf/agent/cmd.py#L41-L46
      cfg.BoolOpt('ovs_all_ports',
                  default=False,
                  help=_('True to delete all ports on all the OpenvSwitch '
                         'bridges. False to delete ports created by '
                         'Neutron on integration and external network '
                         'bridges.'))

  
  But actually ports created by Nova are also deleted. Those also have the iface-id and attached-mac fields.
  https://github.com/openstack/neutron/blob/67b613b795416406fb4fab143b3ec9ba8657711f/neutron/agent/ovsdb/impl_idl.py#L80-L81

  
  # ovs-vsctl --columns=name,external_ids --format=table list Interface
  name             external_ids                                                                                                                                            
  ---------------- ---------------------------------------------------------------------------------
  ...
  "qr-868ef235-bb" {attached-mac="fa:16:3e:bb:94:ca", iface-id="868ef235-bba4-4776-aac9-4b46a9a17def", iface-status=active}
  ...
  "qvof43ccb24-99" {attached-mac="fa:16:3e:70:5c:b0", iface-id="f43ccb24-999e-4f9d-a9e4-07d11b9e5128", iface-status=active, vm-uuid="33c6fffa-f58b-4aab-b5ba-9960c1e02004"}

  
  Not sure which is wrong, the help or the script. Is it supposed to delete ports that were created by nova?

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1853582/+subscriptions