yahoo-eng-team team mailing list archive

[Rodolfo Alonso <ralonsoh@xxxxxxxxxx>]

Public bug reported:

In sanity check "dnsmasq_version_supported", the binary version is checked comparing the version number converted to float. This can lead to errors like the following one:
  version = 2.9
  min_version_required = 2.76

  version < min_version_required ==> False, but v2.9 is older than v2.76

Here we need to use the oslo utils method "convert_version_to_tuple",
and then compare the version tuples.

** Affects: neutron
     Importance: Undecided
     Assignee: Rodolfo Alonso (rodolfo-alonso-hernandez)
         Status: In Progress

** Changed in: neutron
     Assignee: (unassigned) => Rodolfo Alonso (rodolfo-alonso-hernandez)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1859962

Title:
  Sanity checks comparing versions should not use decimal comparison

Status in neutron:
  In Progress

Bug description:
  In sanity check "dnsmasq_version_supported", the binary version is checked comparing the version number converted to float. This can lead to errors like the following one:
    version = 2.9
    min_version_required = 2.76

    version < min_version_required ==> False, but v2.9 is older than
  v2.76

  Here we need to use the oslo utils method "convert_version_to_tuple",
  and then compare the version tuples.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1859962/+subscriptions