yahoo-eng-team team mailing list archive

[OpenStack Infra <1859962@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/702847
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bc0b38b2820b305753120c4f677b2e4bd565d16f
Submitter: Zuul
Branch:    master

commit bc0b38b2820b305753120c4f677b2e4bd565d16f
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Thu Jan 16 11:13:56 2020 +0000

    Use distutils.version to check dnsmasq supported version
    
    Change-Id: If74487a5e437531826437d91b148065eec2bc20c
    Closes-Bug: #1859962


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1859962

Title:
  Sanity checks comparing versions should not use decimal comparison

Status in neutron:
  Fix Released

Bug description:
  In sanity check "dnsmasq_version_supported", the binary version is checked comparing the version number converted to float. This can lead to errors like the following one:
    version = 2.9
    min_version_required = 2.76

    version < min_version_required ==> False, but v2.9 is older than
  v2.76

  Here we need to use the oslo utils method "convert_version_to_tuple",
  and then compare the version tuples.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1859962/+subscriptions