yahoo-eng-team team mailing list archive

[OpenStack Infra <1854940@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/697135
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f758bc998096a8aa20201c95da7da74e07a60bb1
Submitter: Zuul
Branch:    master

commit f758bc998096a8aa20201c95da7da74e07a60bb1
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Tue Dec 3 14:56:32 2019 +0000

    DhcpLocalProcess._enable should not call DhcpLocalProcess.restart
    
    "DhcpLocalProcess._enable", instead of calling
    "DhcpLocalProcess.restart", should only stop the server and continue
    the method. This will avoid getting into a second active wait context.
    
    Change-Id: Id321430c344723363786ab48584b1b48ba69f679
    Closes-Bug: #1854940


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1854940

Title:
  DhcpLocalProcess "_enable" method should not call "restart" -->
  "enable"

Status in neutron:
  Fix Released

Bug description:
  DhcpLocalProcess "DhcpLocalProcess._enable" method should not call
  "DhcpLocalProcess.restart", what is calling "DhcpLocalProcess.enable".
  This call chain will introduce a second active wait [1], that is
  unnecessary.

  PS: IMO, this should be considered "importance = wishlist".

  [1]
  https://github.com/openstack/neutron/blob/26526ba275ecbab5064fb7db9ae2ee2f286a83ca/neutron/agent/linux/dhcp.py#L217

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1854940/+subscriptions