yahoo-eng-team team mailing list archive

[Rodolfo Alonso <ralonsoh@xxxxxxxxxx>]

Public bug reported:

DhcpLocalProcess "DhcpLocalProcess._enable" method should not call
"DhcpLocalProcess.restart", what is calling "DhcpLocalProcess.enable".
This call chain will introduce a second active wait [1], that is
unnecessary.

PS: IMO, this should be considered "importance = wishlist".

[1]
https://github.com/openstack/neutron/blob/26526ba275ecbab5064fb7db9ae2ee2f286a83ca/neutron/agent/linux/dhcp.py#L217

** Affects: neutron
     Importance: Undecided
     Assignee: Rodolfo Alonso (rodolfo-alonso-hernandez)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Rodolfo Alonso (rodolfo-alonso-hernandez)

** Description changed:

  DhcpLocalProcess "DhcpLocalProcess._enable" method should not call
  "DhcpLocalProcess.restart", what is calling "DhcpLocalProcess.enable".
  This call chain will introduce a second active wait [1], that is
  unnecessary.
  
+ PS: IMO, this should be considered "importance = wishlist".
+ 
  [1]
  https://github.com/openstack/neutron/blob/26526ba275ecbab5064fb7db9ae2ee2f286a83ca/neutron/agent/linux/dhcp.py#L217

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1854940

Title:
  DhcpLocalProcess "_enable" method should not call "restart" -->
  "enable"

Status in neutron:
  New

Bug description:
  DhcpLocalProcess "DhcpLocalProcess._enable" method should not call
  "DhcpLocalProcess.restart", what is calling "DhcpLocalProcess.enable".
  This call chain will introduce a second active wait [1], that is
  unnecessary.

  PS: IMO, this should be considered "importance = wishlist".

  [1]
  https://github.com/openstack/neutron/blob/26526ba275ecbab5064fb7db9ae2ee2f286a83ca/neutron/agent/linux/dhcp.py#L217

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1854940/+subscriptions