← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1771559] Re: error while loading icon with pyscss 1.3.5

 

Reviewed:  https://review.opendev.org/714274
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ddc52a7405f0be38629f665d24bcf75022ce0018
Submitter: Zuul
Branch:    master

commit ddc52a7405f0be38629f665d24bcf75022ce0018
Author: Ivan Kolodyazhny <e0ne@xxxxxxxxx>
Date:   Sat Mar 21 19:17:31 2020 +0200

    Fix Horizon to work with the latest pyScss
    
    pyScss v1.3.5 implements 'function-exists' function now. It breaks
    MaterialDesign-Webfont [1] which is provided by xstatic-mdi package.
    
    This patch re-implements FontAwesome-based styles for Material theme to
    not use MaterialDesign-Webfont classes.
    
    Another advantage of this improvement is we can use the latest pyScss
    (once it'll be released) and update xstatic-mdi too.
    
    [1] https://github.com/Templarian/MaterialDesign-Webfont/issues/19
    
    Closes-Bug: #1771559
    Depends-On: https://review.opendev.org/714450
    Change-Id: Ia9e1e807591d4428f585177f521d4cb9d463b917


** Changed in: horizon
       Status: In Progress => Fix Released

** Bug watch added: github.com/Templarian/MaterialDesign-Webfont/issues #19
   https://github.com/Templarian/MaterialDesign-Webfont/issues/19

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1771559

Title:
  error while loading icon with pyscss 1.3.5

Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in python-pyscss package in Ubuntu:
  Confirmed

Bug description:
  Hello,

  Impossible to fetch font awesome icons with material design theme (provided in the package)
  No error in the web development console, but browser show symbol number like "xf44f" instead of showing icons.

  STEPS TO REPRODUCE:
  Use Chrome web browser
  Login to horizon
  Change theme to "Material"
  Try to use Horizon as usual

  Regards.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1771559/+subscriptions


References