yahoo-eng-team team mailing list archive

[OpenStack Infra <1869389@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/715445
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ea999564a5b80dcf13c0c43f107165f0754210b7
Submitter: Zuul
Branch:    master

commit ea999564a5b80dcf13c0c43f107165f0754210b7
Author: Lucas Alvares Gomes <lucasagomes@xxxxxxxxx>
Date:   Fri Mar 27 15:23:49 2020 +0000

    [OVN] HA Chassis Group: Ignore UPDATES when external_ids hasn't changed
    
    The "old" parameter passed to the handle_ha_chassis_group_changes()
    method is a delta object and sometimes it does not contain the
    "external_ids" column (because it hasn't changed).
    
    The absence of that column was misleading that method into believe that
    the "old" object was no longer a gateway chassis and that triggered some
    changes in the HA group. Changing the HA group resulted in the SRIOV
    (external in OVN) ports to start flapping between the gateway chassis.
    
    This patch is adding a check to verify that the "external_ids" column
    has changed before acting on it, otherwise just ignore the update and
    return.
    
    Closes-Bug: #1869389
    Change-Id: I3f7de633e5546dc78c3546b9c34ea81d0a0524d3
    Signed-off-by: Lucas Alvares Gomes <lucasagomes@xxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1869389

Title:
  [OVN] SRIOV (external) ports flapping

Status in neutron:
  Fix Released

Bug description:
  The "old" parameter passed to the handle_ha_chassis_group_changes()
  method is a delta object and sometimes it does not contain the
  "external_ids" column (because it hasn't changed).

  The absence of the "external_ids" column lead to the method into
  believe that the "old" object was no longer a gateway chassis (because
  since the external_ids column wasn't present, the code from
  is_gateway_chassis() returned False) and that triggered some changes
  in the default HA group which the external ports lives.

  The combination of the agents health check (that triggers updates to
  the chassis) plus this problem with the absence of the "external_ids"
  column in the old object for certain updates is resulting in the SRIOV
  (external in OVN) ports to flap between the gateway chassis.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1869389/+subscriptions