← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1869543] [NEW] GET limits API policy is allowed for everyone but policy defaults is admin_or_owner

 

Public bug reported:

limits API policy is allowed for everyone but policy is default to
admin_or_owner[1].

This is because API does not pass the project_id in policy target so that oslo policy can decide the ownership.
https://github.com/openstack/nova/blob/403fc671a6877889d6fb70360e002d9b22b98fc9/nova/api/openstack/compute/limits.py#L77

and if no target is passed then, policy.py add the default targets which is nothing but context.project_id (allow for everyone try to access)
- https://github.com/openstack/nova/blob/c16315165ce307c605cf4b608b2df3aa06f46982/nova/policy.py#L191

There is no owner things in limits and every projects can get its own
limits. We need to make default to RULE_ANY which means allowed to
everyone.

[1]
- https://github.com/openstack/nova/blob/403fc671a6877889d6fb70360e002d9b22b98fc9/nova/policies/limits.py#L27

** Affects: nova
     Importance: Undecided
         Status: New


** Tags: policy

** Tags added: policy

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1869543

Title:
  GET limits API policy is allowed for everyone but policy defaults is
  admin_or_owner

Status in OpenStack Compute (nova):
  New

Bug description:
  limits API policy is allowed for everyone but policy is default to
  admin_or_owner[1].

  This is because API does not pass the project_id in policy target so that oslo policy can decide the ownership.
  https://github.com/openstack/nova/blob/403fc671a6877889d6fb70360e002d9b22b98fc9/nova/api/openstack/compute/limits.py#L77

  and if no target is passed then, policy.py add the default targets which is nothing but context.project_id (allow for everyone try to access)
  - https://github.com/openstack/nova/blob/c16315165ce307c605cf4b608b2df3aa06f46982/nova/policy.py#L191

  There is no owner things in limits and every projects can get its own
  limits. We need to make default to RULE_ANY which means allowed to
  everyone.

  [1]
  - https://github.com/openstack/nova/blob/403fc671a6877889d6fb70360e002d9b22b98fc9/nova/policies/limits.py#L27

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1869543/+subscriptions


Follow ups