yahoo-eng-team team mailing list archive

[Ghanshyam Mann <gmann@xxxxxxxxxxxxxxxxx>]

Public bug reported:

server tags API policy is default to admin_or_owner[1] but API is
allowed for everyone.

We can see the test trying with other project context can access the API
- https://review.opendev.org/#/c/717425

This is because API does not pass the server project_id in policy target
- https://github.com/openstack/nova/blob/cd16ae25c865f25dbb313976b3d8ef9372db80af/nova/api/openstack/compute/server_tags.py#L88

and if no target is passed then, policy.py add the default targets which is nothing but context.project_id (allow for everyone try to access)
- https://github.com/openstack/nova/blob/c16315165ce307c605cf4b608b2df3aa06f46982/nova/policy.py#L191

[1]
- https://github.com/openstack/nova/blob/cd16ae25c865f25dbb313976b3d8ef9372db80af/nova/policies/server_tags.py#L27

** Affects: nova
     Importance: Undecided
         Status: New


** Tags: policy

** Tags added: policy

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1871287

Title:
  server tags  API policy is allowed for everyone even policy defaults
  is admin_or_owner

Status in OpenStack Compute (nova):
  New

Bug description:
  server tags API policy is default to admin_or_owner[1] but API is
  allowed for everyone.

  We can see the test trying with other project context can access the API
  - https://review.opendev.org/#/c/717425

  This is because API does not pass the server project_id in policy target
  - https://github.com/openstack/nova/blob/cd16ae25c865f25dbb313976b3d8ef9372db80af/nova/api/openstack/compute/server_tags.py#L88

  and if no target is passed then, policy.py add the default targets which is nothing but context.project_id (allow for everyone try to access)
  - https://github.com/openstack/nova/blob/c16315165ce307c605cf4b608b2df3aa06f46982/nova/policy.py#L191

  [1]
  - https://github.com/openstack/nova/blob/cd16ae25c865f25dbb313976b3d8ef9372db80af/nova/policies/server_tags.py#L27

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1871287/+subscriptions